#36934: BuiltinLookup.as_sql breaks with params-as-a-tuple
-------------------------------------+-------------------------------------
     Reporter:  Stefan Bühler        |                    Owner:  Jacob
                                     |  Walls
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  6.0
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls <jacobtylerwalls@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"f9b820f8ac50aad025949087e660a551691832e4" f9b820f]:
 {{{#!CommitTicketReference repository=""
 revision="f9b820f8ac50aad025949087e660a551691832e4"
 [6.0.x] Fixed #36934, Refs #35972 -- Coped with params in a tuple in
 BuiltinLookup.as_sql().

 For custom lookups subclassing BuiltinLookup and following the advice in
 the release notes
 to return params in a tuple, this change will obviate the need to audit
 as_sql() in addition to
 process_lhs() to be "resilient against either tuples or lists" as
 described in the release note.

 Regression in 8914f4703cf03e2a01683c4ba00f5ae7d3fa449d.
 }}}
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36934#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c7b65795a-acd3f08b-1704-4045-8341-5bc5b99f5d09-000000%40eu-central-1.amazonses.com.

Reply via email to