#30149: Empty value selected check in Admin Filter prevents subclassing
--------------------------------------+------------------------------------
Reporter: Sardorbek Imomaliev | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Abhimanyu Singh Negi):
Replying to [comment:8 VIZZARD-X]:
> I have submitted a pull request that fixes this issue.
>
> The fix updates `RelatedFieldListFilter.__init__` to explicitly handle
"false-y" string values (like `'False'` and `'0'`) in the query
parameters, ensuring they are interpreted as a boolean `False` rather than
`True`.
>
> I have also added a regression test in `tests/admin_filters/tests.py` to
verify the fix.
>
> PR: https://github.com/django/django/pull/20489
Hi VIZZARD-X, I see you've opened a PR for this ticket. You may want to
assign the ticket to yourself so others know it’s being worked on.
--
Ticket URL: <https://code.djangoproject.com/ticket/30149#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019c6f62d01f-f6e9e777-b3df-4812-ba9f-0e18f0d30b49-000000%40eu-central-1.amazonses.com.
