#36441: Add lazy loading support for GDAL library in `django.contrib.gis.gdal`
-------------------------------------+-------------------------------------
     Reporter:  Josh Thomas          |                    Owner:  Josh
         Type:                       |  Thomas
  Cleanup/optimization               |                   Status:  assigned
    Component:  GIS                  |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:  gdal                 |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Brad Stricherz):

 * needs_better_patch:  0 => 1

Comment:

 I reviewed PR #19529 and ran the new GDAL lazy-loading tests locally. With
 PostGIS configured and GDAL missing, django.setup() no longer errors, and
 the tests in gis_tests.gdal_tests.tests pass.

 There is a missing import in django/contrib/gis/gdal/driver.py:


 {{{
 NameError: name 'classproperty' is not defined
 }}}


 This can be fixed by adding:


 {{{
 from django.utils.functional import classproperty
 }}}



 Once that is corrected, the patch should be ready for checkin. Marking as
 Patch needs improvement until the import is added.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36441#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070199c60aa21b-a655e4a9-fb40-46af-9ac2-28702be17d88-000000%40eu-central-1.amazonses.com.

Reply via email to