#36520: Performance Regression in parse_header_params
-------------------------------------+-------------------------------------
Reporter: David Smith | Owner: Natalia
| Bidart
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by David Smith):
Looking at the original [https://peps.python.org/pep-0333/#environ-
variables PEP 333] under envion variables it says...
> Also note that CGI-defined variables must be strings, if they are
present at all. It is a violation of this specification for a CGI
variable’s value to be of any type other than str.
And the modern [https://peps.python.org/pep-3333/#a-note-on-string-types
PEP3333] it says:
> “Native” strings (which are always implemented using the type named str)
that are used for request/response headers and metadata.
So the comments above about `get_params` working with strings and WSGI
environ being `str` seems to be in line with the spec.
Given how close to the feature freeze we are, I support Carlton's comment
about reverting the change and coming back to it at a more leisurely pace.
--
Ticket URL: <https://code.djangoproject.com/ticket/36520#comment:23>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019911325b64-771dcb09-ed78-4aaf-a03c-20b24df98a8c-000000%40eu-central-1.amazonses.com.
