#30618: AppConfig.name should be a full python path when using the optional
directory.
-------------------------------------+-------------------------------------
Reporter: JungChaeMoon | Owner:
| JungChaeMoon
Type: Bug | Status: closed
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by David Sanders):
Felix, Sarah, Nessita, is this approach worth considering:
Someone requested this in the Django new-features repo (see point 2 on:
https://github.com/django/new-features/issues/62), so I reported it at
#36536 but Sarah pointed out this ticket.
I believe we can address this but using this approach:
- Use `settings.BASE_DIR` and `os.path.relpath()` to compare with the
supplied target directory (instead of using cwd)
- If `settings.BASE_DIR` was never specified (or removed as startproject
sets it) then simply use `app_name`
- If the relative path is outside `settings.BASE_DIR` then ignore it and
also revert to using `app_name`
- If within the project then convert to python path and use that instead.
--
Ticket URL: <https://code.djangoproject.com/ticket/30618#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019864c0ff39-fd82b2af-5f87-4b02-abfa-62189f7576e8-000000%40eu-central-1.amazonses.com.
