#36192: Use semantic HTML for buttons in Django Admin
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Philip
Type: | Narteh
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Thibaud Colas):
I see at least two separate issues here:
1. There are `a` elements with JS behavior added where the `role="button"`
is an improvement but we can go further, and we would be better off with
`<button>`.
2. There are `a` elements that don’t have any JS behavior added, and the
`role="button"` isn’t appropriate. They shouldn’t have a role as they are
links that take users to a separate page.
The admin’s styles are very similar for both types, but we need separate
elements.
I believe PR #19283 only tackles the first point for now.
--
Ticket URL: <https://code.djangoproject.com/ticket/36192#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070198218e65af-ee55bda1-9406-4356-8124-bc9f7f17212e-000000%40eu-central-1.amazonses.com.
