#36380: SQL is formatted for logging regardless of whether it will be logged
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: Bug | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: debug-sql | Triage Stage: Accepted
format_debug_sq |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):
* keywords: debug-sql => debug-sql format_debug_sq
* needs_better_patch: 0 => 1
Comment:
As I just commented in the PR, I think I slightly prefer using
[https://docs.python.org/3/library/logging.html#logging.Logger.isEnabledFor
logging.Logger.isEnabledFor] to conditionally format the sql.
--
Ticket URL: <https://code.djangoproject.com/ticket/36380#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701970e6a4555-032c2664-58f5-4d01-bc4d-60596af7652b-000000%40eu-central-1.amazonses.com.
