#36373: select_related() doesn't work when targeting composite primary keys
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: (none)
Type: Bug | Status: new
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
Looks like something like the following should do
{{{#!diff
diff --git a/django/db/models/query.py b/django/db/models/query.py
index 4f4aad91ef..0472e99144 100644
--- a/django/db/models/query.py
+++ b/django/db/models/query.py
@@ -2680,7 +2680,12 @@ def __init__(self, klass_info, select, db):
)
self.model_cls = klass_info["model"]
- self.pk_idx =
self.init_list.index(self.model_cls._meta.pk.attname)
+ pk_fields = self.model_cls._meta.pk_fields
+ pk_idx = self.init_list.index(pk_fields[0].attname)
+ if (pk_fields_len := len(pk_fields)) > 1:
+ self.pk_idx = slice(pk_idx, pk_fields_len)
+ else:
+ self.pk_idx = pk_idx
self.related_populators = get_related_populators(klass_info,
select, self.db)
self.local_setter = klass_info["local_setter"]
self.remote_setter = klass_info["remote_setter"]
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36373#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070196ab895448-842c43fc-7e07-4cd7-944a-4be156f90a04-000000%40eu-central-1.amazonses.com.
