#31170: dismissRelatedLookupPopup doesn't trigger change event
-------------------------------------+-------------------------------------
Reporter: J. David Ibáñez | Owner: Kairat
| Makym
Type: Bug | Status: closed
Component: contrib.admin | Version: 3.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):
In [changeset:"a245604277eb9edeba234dacf199890766462709" a245604]:
{{{#!CommitTicketReference repository=""
revision="a245604277eb9edeba234dacf199890766462709"
Fixed #36284, Refs #31170 -- Ensured related lookup popups are closed
properly.
In the admin, when selecting related objects via the helpers defined in
`RelatedObjectLookups.js`, the `dismissRelatedLookupPopup` function was
attempting to access `window.relatedWindows`, which does not exist in
real execution, causing related lookup popups to remain open.
This change ensures that this code correctly accesses the module-local
`relatedWindows` by explicitly assigning it to `window.relatedWindows`.
Regression in 91bebf1adb43561b54bac18e76224759dc70acb3.
Thanks Matthias Kestenholz for the report, the fix ideas, and testing.
Co-authored-by: Matthias Kestenholz <[email protected]>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/31170#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070195f244d88d-12271cd4-ffa9-47e9-97da-1708b1f93ec0-000000%40eu-central-1.amazonses.com.
