#36191: FileSystemStorage with allow_overwrite=True does not truncate previous 
file
-------------------------------------+-------------------------------------
     Reporter:  Gaël UTARD           |                    Owner:  Gaël
                                     |  UTARD
         Type:  Bug                  |                   Status:  new
    Component:  File                 |                  Version:  5.2
  uploads/storage                    |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Baptiste Mispelon):

 * has_patch:  1 => 0
 * resolution:  fixed =>
 * stage:  Ready for checkin => Accepted
 * status:  closed => new
 * version:  5.1 => 5.2

Comment:

 The bug is still present in the `file_move_safe()` function [1] which can
 be triggered under some circumstances when calling
 `FileSystemStorage._save()` [2] (observed in 5.2 but I'm fairly sure the
 same is true in `main`).

 Because it's essentially the same bug I'm reopening this one instead of
 creating a new one, I hope that's OK.

 I'm also leaving the Release Blocker status on due to the data corruption
 aspect of this issue.

 [1]
 
https://github.com/django/django/blob/f7f38f3a0b44d8c6d14344dae66b6ce52cd77b55/django/core/files/move.py#L57
 [2]
 
https://github.com/django/django/blob/f7f38f3a0b44d8c6d14344dae66b6ce52cd77b55/django/core/files/storage/filesystem.py#L99
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36191#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070195fd646096-4d6579e4-4ac9-4626-a6d5-c494c2414288-000000%40eu-central-1.amazonses.com.

Reply via email to