#36160: Django serve view does not respect X_FRAME_OPTIONS = "SAMEORIGIN"
-------------------------------------+-------------------------------------
Reporter: miratcan | Type:
| Uncategorized
Status: new | Component:
| contrib.staticfiles
Version: 5.1 | Severity: Normal
Keywords: static, headers | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
In my Django project, I needed to display an uploaded file inside an
<iframe>. However, I noticed that Django's built-in serve view does not
respect the X_FRAME_OPTIONS = "SAMEORIGIN" setting, which prevents the
file from being embedded in an iframe.
After investigating, I found that the serve view in Django does not modify
the response headers related to X_FRAME_OPTIONS, meaning it defaults to
Django's global security settings.
**Serve view:**
https://github.com/django/django/blob/c6ace896a2da73356f7c9a655bbe32a0e3ce0435/django/views/static.py#L28
**FileResponse implementation:**
https://github.com/django/django/blob/12b9ef38b3ff7f5b8b24a5f42e8923fdb6db44bb/django/http/response.py#L572
Since serve acts as a wrapper around FileResponse, I expected it to either
respect X_FRAME_OPTIONS or provide a way to override it.
Would it be possible to modify the serve view to allow overriding
X_FRAME_OPTIONS explicitly?
--
Ticket URL: <https://code.djangoproject.com/ticket/36160>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070194b6f6bd57-e73d6469-6aeb-4b2f-9336-c0cd0e1847dc-000000%40eu-central-1.amazonses.com.
