#36120: Calling .update() on the virtual "pk" field for composite primary keys
raises AttributeError
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: (none)
Type: Bug | Status: new
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Jacob Walls:
Old description:
> Do we want to support `.update(pk=...` for composite primary keys?
>
> If not, let's raise a friendly error.
>
> Rough test for demo purposes:
> {{{#!diff
> diff --git a/tests/composite_pk/test_update.py
> b/tests/composite_pk/test_update.py
> index ec770230fc..6164e0de90 100644
> --- a/tests/composite_pk/test_update.py
> +++ b/tests/composite_pk/test_update.py
> @@ -1,4 +1,5 @@
> from django.db import connection
> from django.test import TestCase
>
> from .models import Comment, Tenant, TimeStamped, Token, User
> @@ -175,3 +176,7 @@ class CompositePKUpdateTests(TestCase):
>
> with self.assertRaisesMessage(ValueError, msg):
> Comment.objects.update(user=User())
> +
> + def test_update_lhs_pk(self):
> + qs = Comment.objects.filter(user__email=self.user_1.email)
> + qs.update(pk=(1, 100)) # supported?
> }}}
>
> ----
> {{{#!diff
> ======================================================================
> ERROR: test_update_lhs_pk
> (composite_pk.test_update.CompositePKUpdateTests.test_update_lhs_pk)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/source/django/tests/composite_pk/test_update.py", line
> 182, in test_update_lhs_pk
> qs.update(pk=(1, 100)) # decide whether to support this or not
> ~~~~~~~~~^^^^^^^^^^^^^
> File "/Users/source/django/django/db/models/query.py", line 1254, in
> update
> rows = query.get_compiler(self.db).execute_sql(ROW_COUNT)
> File "/Users/source/django/django/db/models/sql/compiler.py", line
> 2068, in execute_sql
> row_count = super().execute_sql(result_type)
> File "/Users/source/django/django/db/models/sql/compiler.py", line
> 1610, in execute_sql
> sql, params = self.as_sql()
> ~~~~~~~~~~~^^
> File "/Users/source/django/django/db/models/sql/compiler.py", line
> 2044, in as_sql
> values.append("%s = %s" % (qn(name), placeholder))
> ~~^^^^^^
> File "/Users/source/django/django/db/models/sql/compiler.py", line 568,
> in quote_name_unless_alias
> r = self.connection.ops.quote_name(name)
> File "/Users/source/django/django/db/backends/sqlite3/operations.py",
> line 190, in quote_name
> if name.startswith('"') and name.endswith('"'):
> ^^^^^^^^^^^^^^^
> AttributeError: 'NoneType' object has no attribute 'startswith'
>
> ----------------------------------------------------------------------
> }}}
New description:
Do we want to support `.update(pk=...` for composite primary keys?
If not, let's raise a friendly error.
Rough test for demo purposes:
{{{#!diff
diff --git a/tests/composite_pk/test_update.py
b/tests/composite_pk/test_update.py
index ec770230fc..3bd65d918a 100644
--- a/tests/composite_pk/test_update.py
+++ b/tests/composite_pk/test_update.py
@@ -175,3 +175,7 @@ class CompositePKUpdateTests(TestCase):
with self.assertRaisesMessage(ValueError, msg):
Comment.objects.update(user=User())
+
+ def test_update_lhs_pk(self):
+ qs = Comment.objects.filter(user__email=self.user_1.email)
+ qs.update(pk=(1, 100)) # supported?
}}}
----
{{{#!diff
======================================================================
ERROR: test_update_lhs_pk
(composite_pk.test_update.CompositePKUpdateTests.test_update_lhs_pk)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/source/django/tests/composite_pk/test_update.py", line 182,
in test_update_lhs_pk
qs.update(pk=(1, 100)) # decide whether to support this or not
~~~~~~~~~^^^^^^^^^^^^^
File "/Users/source/django/django/db/models/query.py", line 1254, in
update
rows = query.get_compiler(self.db).execute_sql(ROW_COUNT)
File "/Users/source/django/django/db/models/sql/compiler.py", line 2068,
in execute_sql
row_count = super().execute_sql(result_type)
File "/Users/source/django/django/db/models/sql/compiler.py", line 1610,
in execute_sql
sql, params = self.as_sql()
~~~~~~~~~~~^^
File "/Users/source/django/django/db/models/sql/compiler.py", line 2044,
in as_sql
values.append("%s = %s" % (qn(name), placeholder))
~~^^^^^^
File "/Users/source/django/django/db/models/sql/compiler.py", line 568,
in quote_name_unless_alias
r = self.connection.ops.quote_name(name)
File "/Users/source/django/django/db/backends/sqlite3/operations.py",
line 190, in quote_name
if name.startswith('"') and name.endswith('"'):
^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'startswith'
----------------------------------------------------------------------
}}}
--
--
Ticket URL: <https://code.djangoproject.com/ticket/36120#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070194869a96d3-a71393f1-3782-4863-8fa1-74303bfad130-000000%40eu-central-1.amazonses.com.
