#36038: Added a test case for the display_for_field function when a FileField is
passed.
-------------------------------------+-------------------------------------
     Reporter:  Antoliny             |                    Owner:  Antoliny
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  contrib.admin        |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:  display_for_field,   |             Triage Stage:  Accepted
  FileFIeld                          |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce):

 You're right that this is already covered by existing tests and this PR
 would add double cover.
 The existing assert is "strong" enough that changes to `display_for_field`
 for FileField would make the existing test fail.
 I would prefer we add tests where we are [https://djangoci.com/job/django-
 coverage/HTML_20Coverage_20Report/ missing coverage] or in parallel with a
 ticket for which the tests add value. Otherwise, it feels unnecessary
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36038#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070194274bbc47-f8cd5085-6029-4aa5-87d8-d52f8a288256-000000%40eu-central-1.amazonses.com.

Reply via email to