#36018: Sites.objects.get_current() will always return the settings.SITE_ID,
even
when the optional request is passed
-------------------------------+--------------------------------------
Reporter: DeVon Jackson | Owner: (none)
Type: Bug | Status: closed
Component: contrib.sites | Version: 5.1
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Tim Graham):
* resolution: => invalid
* status: new => closed
Comment:
You're proposing a change in
[https://docs.djangoproject.com/en/dev/ref/contrib/sites/#django.contrib.sites.shortcuts.get_current_site
the documented behavior]:
"A function that checks if django.contrib.sites is installed and returns
either the current Site object or a RequestSite object based on the
request. It looks up the current site based on request.get_host() if the
SITE_ID setting is not defined."
Changing it would be backward incompatible. If you want to argue for a
behavior change, you should research why the current behavior exists and
explain the rationale for your proposal on
[https://forum.djangoproject.com/c/internals/5 the Django forum].
--
Ticket URL: <https://code.djangoproject.com/ticket/36018#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193d19e9970-7a1ca4c1-ba70-4d35-980b-7e1fb93166bd-000000%40eu-central-1.amazonses.com.
