#36004: Fixing Icons: auto, sun, and moon
-------------------------------------+-------------------------------------
Reporter: Pablo Bengoechea | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Description changed by Pablo Bengoechea:
Old description:
> Regarding ticket #35829, which addresses the migration of icons from the
> Font-Awesome-SVG-PNG library to the main Font Awesome repository, the
> following has been identified:
>
> The icons icon-sun, icon-moon, and icon-auto are not stored in the img
> folder within the directory contrib/admin/static/admin/img.
>
> These icons are directly called from the
> django/contrib/admin/templates/admin/base.html file.
>
> It is unclear which library these icons originate from, as I did not find
> them in the Font-Awesome-SVG-PNG library.
>
>
> My proposal to address this issue is as follows:
>
> Identify the original source of the icon-sun, icon-moon, and icon-auto
> icons in Font Awesome version 6.7.1, download these icons from this
> version in an appropriate format (SVG), and store them in the img folder
> within the directory contrib/admin/static/admin/img. Then, update the
> base.html file to reference these icons from the new location.
>
> Finally, test the changes to ensure that the icons load correctly and
> retain their functionality in the relevant views. I am not sure if it
> would be best to combine this with ticket #35829
New description:
Regarding ticket #35829, which addresses the migration of icons from the
https://github.com/Rush/Font-Awesome-SVG-PNG library to the main Font
Awesome repository, the following has been identified:
The icons icon-sun, icon-moon, and icon-auto are not stored in the img
folder within the directory contrib/admin/static/admin/img.
These icons are directly called from the
django/contrib/admin/templates/admin/base.html file.
It is unclear which library these icons originate from, as I did not find
them in the https://github.com/Rush/Font-Awesome-SVG-PNG library.
My proposal to address this issue is as follows:
Identify the original source of the icon-sun, icon-moon, and icon-auto
icons in Font Awesome version 6.7.1, download these icons from this
version in an appropriate format (SVG), and store them in the img folder
within the directory contrib/admin/static/admin/img. Then, update the
base.html file to reference these icons from the new location.
Finally, test the changes to ensure that the icons load correctly and
retain their functionality in the relevant views. I am not sure if it
would be best to combine this with ticket #35829
--
--
Ticket URL: <https://code.djangoproject.com/ticket/36004#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193bb6090d7-00a68cb8-03fb-489b-b42c-405f39481657-000000%40eu-central-1.amazonses.com.
