#36002: Errors in RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings
and code comments
-------------------------------------+-------------------------------------
Reporter: Anders Einar Hilden | Owner: Anders
Type: | Einar Hilden
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: dev
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
RemoteUserMiddleware, | Unreviewed
PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Anders Einar Hilden):
I do not concurre with that evaluation. The docstring & comments
spesifically say "the ``REMOTE_USER`` request header" - But a request
header can never be named "REMOTE_USER", if you send a header named
"REMOTE-USER", it will be named HTTP_REMOTE_USER in the dict, not
REMOTE_USER. Thus the default can only be passed as a direct envirionment
variable, it can never come from a header.
--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193ba960298-ece87eda-1cc6-4bf3-b794-b974f40ca216-000000%40eu-central-1.amazonses.com.
