#35980: PyPI will require uploaded source distribution filenames to comply with 
PEP
625 and contain the normalized project name "django"
--------------------------------------+------------------------------------
     Reporter:  Sarah Boyce           |                    Owner:  (none)
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Core (Other)          |                  Version:  5.1
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Nick Pope):

 * has_patch:  0 => 1

Comment:

 Certainly using v69.3.0 as a minimum version for `setuptools` should make
 us compliant with PEP 625.

 But, honestly, I remain as baffled as last time I looked into this. I
 found
 [https://github.com/pypa/setuptools/issues/3593#issuecomment-2176739508
 this comment] which basically says that the source distribution filename
 should follow the same normalisation rules as the binary distribution
 filename and that states that uppercase should be replaced with lowercase.
 So why, oh why, do I get the following?

 {{{
 $ git clean -fdX
 $ python -m build
 ...
 Successfully built django-5.2.dev20241206115354.tar.gz and Django-5.2-py3
 -none-any.whl
 }}}

 I even tried with the latest `setuptools`, at the time of writing v75.6.0.

 While we could go to the PyPA and say, "What the heck?", it's probably
 just easier to change `name = Django` to `name = django` in
 `pyproject.toml` and move on:

 {{{
 $ git clean -fdX
 $ python -m build
 ...
 Successfully built django-5.2.dev20241206115354.tar.gz and django-5.2-py3
 -none-any.whl
 }}}

 It also seems concerning that the version in the wheel filename is
 incomplete...

 Here is a draft [https://github.com/django/django/pull/18891 PR] for
 consideration.

 I'm not sure what we'll have to do regarding backports, but it might mean
 a more significant backport of the `setup.cfg` to `pyproject.toml`
 changes.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35980#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/010701939d4701c8-6d9da1a1-038e-4c39-879d-4792e59b9ae2-000000%40eu-central-1.amazonses.com.

Reply via email to