#35693: Password validators aren't callable
-------------------------------------+-------------------------------------
Reporter: iamkorniichuk | Owner: Antoliny
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: validators password | Triage Stage: Accepted
callable |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce):
Also commented on the PR but I'm not 100% sure this is worth it just for
the consistency, but if we were to do this:
* validators also have an `__eq__` method, if we are adding the call for
consistency, I feel like we should add this for consistency. We should
also consider whether to inherit from `BaseValidator` for example.
* I would expect the docs in the
[https://docs.djangoproject.com/en/5.1/topics/auth/passwords/#writing-
your-own-validator Writing your own validator] section to be updated.
* Any custom validator not provided by Django will not have this change
I think the next steps would be to raise this on
[https://forum.djangoproject.com/c/internals/5 forum] and see if there is
a consensus that this additional is valuable and wanted.
I would suggest instead that the
[https://docs.djangoproject.com/en/5.1/topics/auth/passwords/#module-
django.contrib.auth.password_validation Password validation] docs make it
clear that these validators are not field validators and perhaps say
"password validator" instead of "validator" consistently
--
Ticket URL: <https://code.djangoproject.com/ticket/35693#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701939af09503-28261a68-733d-408b-9141-32a8f51c9139-000000%40eu-central-1.amazonses.com.
