#35842: JSONField has_key, has_keys, has_any_keys lookups do not properly handle
quotes on Oracle and SQLite
-------------------------------------+-------------------------------------
Reporter: Simon Charette | Owner: Sage
| Abdullah
Type: Bug | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle sqlite json | Triage Stage: Accepted
key quote |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sage Abdullah):
Replying to [comment:13 Simon Charette]:
> Re-reading your message and the release date (2024-10-21) I assume you
meant 3.47.0 and not 3.37.0.
>
> I guess this means we could conditionally include entries in
`django_test_expected_failures` based on `sqlite3.sqlite_version`?
Oops, yep! I meant 3.47.0, sorry. Thanks for figuring it out 😄
I think so,
[https://github.com/django/django/blob/3d508ececbd3b7b652aedc66b0d3d2c7baa4795a/django/db/backends/sqlite3/features.py#L69-L70
we already have some conditionals in django_test_skips], so we should be
OK with changing `django_test_skips` into a `cached_property` and check
`Database.sqlite_version_info`.
Although it's going to be tricky to prove it in CI without adding/updating
one of the jobs to use a newer SQLite version, as you experienced
yourself.
I think it would still be useful to have at least one configurable SQLite
version though, so we can test with the latest SQLite independently of the
installed Python. That would be separate to this ticket, but I'd be happy
to make the PR if we want to have that.
--
Ticket URL: <https://code.djangoproject.com/ticket/35842#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019395e19de7-f7d7a966-c5f4-4735-8162-99a67d255e66-000000%40eu-central-1.amazonses.com.
