#35934: Migrations tests fail and leave behind files if 
tests/migrations/migrations
exists
-------------------------------------+-------------------------------------
     Reporter:  Jacob Walls          |                    Owner:  Jacob
         Type:                       |  Walls
  Cleanup/optimization               |                   Status:  closed
    Component:  Migrations           |                  Version:  dev
     Severity:  Normal               |               Resolution:  needsinfo
     Keywords:                       |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):

 * resolution:   => needsinfo
 * status:  assigned => closed

Comment:

 Hello Jacob, thank you for the report and the additional details! One
 thing I'm not clear on is whether the unexpected issue first occurred
 because a failed test left the migrations folder behind or undeleted.

 Was that the case? If so, I think we should focus on identifying the tests
 that don't clean up properly after a failure. However, I would not add
 assertions to check that certain folders don't exist, as this feels a bit
 like a code smell to me.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35934#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070193636c40c9-9a396dd7-2bcb-4082-8427-cfd12d42cb79-000000%40eu-central-1.amazonses.com.

Reply via email to