#35894: Move away from the term "patch" to refer to a contribution/pull request 
in
the contributor documentation
-------------------------------------+-------------------------------------
     Reporter:  Baptiste Mispelon    |                    Owner:  Baptiste
         Type:                       |  Mispelon
  Cleanup/optimization               |                   Status:  assigned
    Component:  Documentation        |                  Version:  5.0
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Comment (by Baptiste Mispelon):

 Thanks for your beed back Natalia!

 I do not agree that "Pull request" is a github-specific term (it might
 have started that way, but it is not anymore). It's also used by:
 - Atlassian / bitbucket [1]
 - Amazon / CodeCommit [2]
 - Gitea [3]
 - Codeberg [4]

 And for what it's worth, wikipedia also says that "pull request" and
 "merge request" are equivalent [5].

 But even with all this, my argument is that we should meet the
 contributors where they are, and today that's on github, using pull
 requests. If and when that process changes, we can amend the documentation
 again.

 With the current state of my merge request, no URL has changed, and the
 only headings that were modified did not lead to any internal links being
 broken. Plus there's currently no documented policy I could find around
 backwards-compatibility of anchors.

 The change I'm proposing in this merge request is not to erase "patch"
 altogether, nor is it to replace all of its occurences by "pull request".
 The word "patch" has been kept where it reflects the reality, and replaced
 by a variation of "pull request", "change", "contribution", "proposal",
 ... where it makes more sense.


 [1] https://www.atlassian.com/git/tutorials/making-a-pull-request
 [2] https://docs.aws.amazon.com/codecommit/latest/userguide/pull-
 requests.html
 [3] https://docs.gitea.com/next/usage/pull-request
 [4] https://docs.codeberg.org/collaborating/pull-requests-and-git-flow/
 [5]
 https://en.wikipedia.org/wiki/Distributed_version_control#Pull_requests
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35894#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019340b706cf-883a12ef-1d7c-4813-a51d-e347de6fbbd2-000000%40eu-central-1.amazonses.com.

Reply via email to