#35894: Move away from the term "patch" to refer to a contribution/pull request
in
the contributor documentation
-------------------------------------+-------------------------------------
Reporter: Baptiste Mispelon | Owner: Baptiste
Type: | Mispelon
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):
* stage: Unreviewed => Accepted
* summary: Rename "patch" to "pull request" in the contributor
documentation =>
Move away from the term "patch" to refer to a contribution/pull
request in the contributor documentation
Comment:
Replying to [comment:3 Tim Graham]:
> I'd prefer not to rename files and cause external broken links
([https://www.w3.org/Provider/Style/URI Cool URIs Don't Change]). (E.g.
you proposed to rename ....writing-code/submitting-patches.txt to
.../writing-code/pull-requests.txt.)
>
> You also proposed to remove the ".. _patch-review-checklist:" heading
which I have used extensively in Trac comments as well as on the
PatchReviewChecklist wiki page (but if the page is renamed the link will
break anyway).
I agree we should be careful not to break links here
I'm in favor of updating from patch, to either "pull
request"/"contribution"/"solution"/"fix"
I think "Has patch" -> "Has pull request" as when someone marks this as
Yes, I expect to see something reviewable in GitHub which has also
triggered our CI
"Patch needs improvement" could be "Requested changes" (I have stolen that
from GitHub but is perhaps less of a GitHubism)
Will review the PR in detail for more specific cases
--
Ticket URL: <https://code.djangoproject.com/ticket/35894#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701930677cd7f-d20aa196-037d-4673-ac9f-6f8ba9208b4d-000000%40eu-central-1.amazonses.com.
