#35894: Rename "patch" to "pull request" in the contributor documentation
-------------------------------------+-------------------------------------
Reporter: Baptiste Mispelon | Owner: Baptiste
Type: | Mispelon
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham):
There were some recent changes along these lines in
55a2e3136b13d1af95a4129001dac963c26d8415.
I'd prefer not to rename files and cause external broken links
([https://www.w3.org/Provider/Style/URI Cool URIs Don't Change]). (E.g.
you proposed to rename ....writing-code/submitting-patches.txt to
.../writing-code/pull-requests.txt.)
You also proposed to remove the ".. _patch-review-checklist:" heading
which I have used extensively in Trac comments as well as on the
PatchReviewChecklist wiki page (but if the page is renamed the link will
break anyway).
It's possible Django will use Git, GitHub, and "pull requests" forever,
but it might be worth considering if these specific terms should really be
embedded in URLs.
--
Ticket URL: <https://code.djangoproject.com/ticket/35894#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701930403f694-b1ee2234-947d-496a-a162-97dd7151bfac-000000%40eu-central-1.amazonses.com.
