#35674: Provide a check for settings removed (post deprecation)
-------------------------------------+-------------------------------------
Reporter: Serafeim | Owner: Ronny
Papastefanos | Vedrilla
Type: New feature | Status: assigned
Component: Core (System | Version: 5.1
checks) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):
Replying to [comment:19 Tim Graham]:
> I remain unconvinced that this is a wise change. Are we going to
document an ever growing list of
[https://docs.djangoproject.com/en/dev/topics/settings/#creating-your-own-
settings a disallowed settings names]? Disallowing something so generic as
`LOGOUT_URL` seems like it will cause unneeded annoyance.
>
> Although the check could be disabled (usage of one disallowed setting
requires disabling the check completely), this is more of a backward-
incompatible change than a new feature.
>
> We have had
[https://github.com/django/django/commit/6192bffb130132461e55e5fe7a7eaaa9a166d08f
temporary compatibility checks] to point out deprecated settings. I guess
that may have been more visible than a deprecation warning in the case of
`DEFAULT_FILE_STORAGE`.
Hey Tim, thank you for sharing your thoughts. I appreciate your
engagement. However, I want to clarify that the change was discussed and
agreed upon in the Django Forum, which is where these conversations
typically take place. The audience for ticket comments is smaller, so I
encourage you to continue the discussion in the forum. This way, we can
follow the usual process and involve more people in the conversation.
Personally, I believe practicality beats purity, and in this case, the
benefits of letting users know outweigh any potential issues with someone
who chose to use a setting name that was deprecated by Django. Having said
that, I agree that we should consider a way to ignore a subset of
deprecated setting names. I'll consider this when reviewing the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/35674#comment:20>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701929ffbd3f9-f51d583f-ec59-4a64-b179-42d8a7766b2d-000000%40eu-central-1.amazonses.com.
