#35795: Admin forms: "Delete" button should be a button
-------------------------------------+-------------------------------------
Reporter: Alena Volkova | Owner: Jay Patel
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: Accessibility, WCAG | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):
* needs_better_patch: 0 => 1
Comment:
I've reviewed the PR. Except for the two entries in
`django/contrib/admin/templates/admin/actions.html` (which currently have
a `href="#"`), all the other (currently modified) links are truly a link:
* Delete link in `django/contrib/admin/templates/admin/submit_line.html`
takes the user to a confirmation page
* Reset password link in
`django/contrib/auth/templates/auth/widgets/read_only_password_hash.html`
takes the user to a reset password page
I'm don't think we should be changing the links for Delete and Reset
Password to have `role="button"` since they do not submit any form nor
perform any action on their own. They truly take the user to another page.
--
Ticket URL: <https://code.djangoproject.com/ticket/35795#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701929303a986-3d19ebe8-9558-4fb7-8650-41d0f2061986-000000%40eu-central-1.amazonses.com.
