#35834: PasswordResetForm doesn't forward exceptions when email sending fails
-------------------------------------+-------------------------------------
Reporter: Olivier LEVILLAIN | Type:
| Uncategorized
Status: new | Component:
| contrib.auth
Version: 5.1 | Severity: Normal
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
In PasswordResetForm, the code to send the reset email is:
{{{
try:
email_message.send()
except Exception:
logger.exception(
"Failed to send password reset email to %s",
context["user"].pk
)
}}}
==> if the email sending fails (because for instance of an email password
change), the user who asked for a reset will see it as a success and never
receive his email and the admin will have to look at the logs to
understand what happened
It would be better if the exception was forwarded and an error appears on
the users screen.
--
Ticket URL: <https://code.djangoproject.com/ticket/35834>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107019286e74eb6-b1600eda-1fb9-4a5b-a146-410f8155f33c-000000%40eu-central-1.amazonses.com.
