#35829: Update/Fix Font Awesome icons
-------------------------------------+-------------------------------------
Reporter: stefan6419846 | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by stefan6419846):
> I agree with this conclusion as far as I can see. Though note that the
standalone SVG files do seem to be licensed under MIT as per
https://github.com/Rush/Font-Awesome-SVG-PNG/?
>
> Wouldn't this be an issue that https://github.com/Rush/Font-Awesome-SVG-
PNG has to deal with?
Yes, this repository is marked as MIT, although mentioning in the README
that the Font Awesome font is subject to OFL-1.1. Unfortunately, just
relying on this information is not sufficient. In theory, every user of
the package (or every part of the supply chain, depending on how you want
to name it) is required to review this and look for possible
inconsistencies. With the usual warranty disclaimers of FOSS packages it
ultimately is the task of the final distributor to verify the correctness
of the provided data - especially if Django is part of commercial
applications where contracts specify warranty-related clauses. (Please
note that this might differ depending on the jurisdiction/country. AFAIK
this is what holds true for Germany.)
For now, it is not completely clear for me which version of Font Awesome
Django currently uses. According to the history at
https://github.com/django/django/commits/main/django/contrib/admin/static/admin/img/README.txt
and the upstream history, this might be version 4.3.0, which would match
the README statement about OFL-1.1: https://github.com/Rush/Font-Awesome-
SVG-PNG/blob/31dd85aef85aed8cfbe8c8d4423ca9a262a23620/package.json#L24
https://github.com/Rush/Font-Awesome-SVG-PNG/issues/79 already is an
upstream issue about this. Depending on the Font Awesome version,
different terms are relevant, which I have documented there a bit more.
> > * Changing the color of individual files or re-arranging them can more
likely be considered derivative work, usually requiring using a different
name under the terms of the OFL-1.1 and applying the OFL-1.1 to these
files.
>
> I'm not seeing name matching between what we have in Django and what I
have downloaded from Font Awesome. Could you please provide a few specific
examples?
This is about using the reserved font name "Font Awesome", which according
to the OFL-1.1 cannot be used for derivatives of the original font. This
initially arises from ''Font-Awesome-SVG-PNG'' as well, but still holds
true for Django as well. To be honest, applying the name clause (3) to
standalone SVG icons does not necessarily make sense and only occurs for
the problematic Font Awesome version 4.
> I don't object with this proposal, it feels like a good refresh though
it would need more work than that. We'd need the proper coloring and
resizing to be applied, and potentially a re-take of all the admin
screenshots used in the docs.
At least coloring and resizing should ideally be easy enough due to SVG
files basically being XML with plain drawing operations. As for how
different the icons are between the different versions, this is something
which would have to be evaluated - the initial problem with this is
finding the matching Font Awesome names for the symbols used by Django, as
this is not documented and Django renamed the files to better match the
corresponding use cases. (For example, ''eye.svg'' has been renamed to
''icon-viewlink.svg'' in Django.)
> If we eventually accept this ticket, would you be able to help with
this? Thanks!
Yes, I should be able to help with this.
--
Ticket URL: <https://code.djangoproject.com/ticket/35829#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701927aced446-b9478c15-94d1-4fbf-9829-a6621ecac411-000000%40eu-central-1.amazonses.com.
