#35799: Plus icon should be right of text for adding an inline item in admin for
RTL support
-------------------------------+---------------------------------------
     Reporter:  Mario Munoz    |                    Owner:  Mario Munoz
         Type:  Bug            |                   Status:  assigned
    Component:  contrib.admin  |                  Version:  5.0
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  1
-------------------------------+---------------------------------------
Comment (by Mario Munoz):

 There was no CSS class specified for the link created within the "add-row"
 element generated by the {{{ inline.js }}} file. Also found duplication of
 the CSS that generates the icon for "addlink" icon. It was in both the {{{
 base.css }}} file as well as the {{{ forms.css }}} file, although the {{{
 forms.css }}} also had a font-size property.

 With no changes to the CSS, the {{{ addlink }}} class had no effect on the
 affected element because of the duplication and CSS specificity rules.
 (The rule in {{{ forms.css }}} had higher precedence.)

 We standardized the usage of the {{{ addlink }}} class by removing the css
 rule in {{{ forms.css }}} for tabular and stacked elements. There was an
 additional property set for ul elements, but that is being addressed in
 ticket #35804.

 By removing the css rules in {{{ forms.css }}} and adding the class {{{
 addlink }}} class in the affected element, it is now displaying correctly,
 and should be easier to maintain in the future.

 See screenshot for fix.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35799#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070192395df4ae-a5f298bf-f5fd-48a8-a5b3-9f0ec7317e1f-000000%40eu-central-1.amazonses.com.

Reply via email to