#35444: Add generic support for order by to Aggregate
-------------------------------------+-------------------------------------
Reporter: Chris M | Owner: Chris M
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: orderableaggmixin | Triage Stage: Accepted
aggregate |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Chris M):
Thanks for the bump, Simon. I got into a busy period at work, but I was
just talking to my team about how I needed to get back to work on this PR
if I wanted to get it in for 5.2. So the timing works out well.
https://github.com/django/django/compare/main...camuthig:django:merge-
orderable-agg-mixin
I did hit a couple of bumps along the way but nothing blocking yet. I have
what appears to be a working feature tested locally against Sqlite and
Postgres and need to get the time to update to documentation and write
tests. In my code I am porting over the `StringAgg` function into the
standard DB module and I am shifting the postgres specific implementation
to be a subclass of it, so the existing postgres StringAgg tests work as a
full regression test for that database backend, but we don't have that
same coverage for the other backends yet.
I'm curious your thoughts on a few things:
1. Generally if you think the current path of the code is right or needs
changes. I can convert this diff link into a draft PR if that would help.
2. If you can point me in the right direction for any documentation you
think should be updated. I haven't started working through that just yet.
3. What do you think the best way to test this is? The Postgres aggregate
tests are very thorough, so I was thinking it might work to take all of
the string agg related tests from there and move them into a new test file
that isn't just run for the Postgres backend?
--
Ticket URL: <https://code.djangoproject.com/ticket/35444#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701907e1d211a-60400dbf-bf69-4dfe-bdf6-40a259e902f9-000000%40eu-central-1.amazonses.com.
