#35404: Admin fieldset multiple flexbox regressions
-------------------------------------+-------------------------------------
Reporter: minusf | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: css admin fieldset | Triage Stage: Accepted
accessibility |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):
* keywords: css admin fieldset => css admin fieldset accessibility
Comment:
Replying to [comment:9 minusf]:
> Regarding `help_text`, I think that with this small font `line-height:
normal` is not enough:
> {{{#!diff
> M django/contrib/admin/static/admin/css/base.css
> @@ -268,6 +268,7 @@ hr {
> .help, p.help, form p.help, div.help, form div.help, div.help li {
> font-size: 0.6875rem;
> color: var(--body-quiet-color);
> + line-height: 1.5;
> }
> ยท
> div.help ul {
> }}}
I don't think, taking into account the way the admin is already, this css
change clearly fixes an issue/bug.
I think a wider discussion on whether the fonts and spacing in the admin
is too small (with the accessibility team involved) is a good idea, but
out of scope of this ticket.
There are many small tweaks we can make to css and there is a lot of
subjectivity around what looks "better", so let's fix the issue as
reported and create further discussions as necessary. Then the changes we
make are scoped out and made to all required areas at once, rather than a
series of many small tweaks requiring many reviews. I hope that makes
sense ๐
--
Ticket URL: <https://code.djangoproject.com/ticket/35404#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018f61de4d3d-ff9b793c-a0fe-4521-9af0-db187507e312-000000%40eu-central-1.amazonses.com.
