#35372: Remove convenience imports in django/core/mail/__init__.py
-------------------------------------+-------------------------------------
Reporter: Danic | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Core (Mail) | Version: 5.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* resolution: => wontfix
* status: new => closed
* summary: Obsolete code in django\core\mail\__init__.py ? => Remove
convenience imports in django/core/mail/__init__.py
Old description:
> I found the following comment in django\core\mail\__init__.py
>
> # Imported for backwards compatibility and for the sake
> # of a cleaner namespace. These symbols used to be in
> # django/core/mail.py before the introduction of email
> # backends and the subsequent reorganization (See #10355)
>
> #10355 relates to Django 1. As it's out of support, it maybe doesn't make
> sense to keep the backwards compatibility. Would it make sense to have a
> look at that file and check what of the code can be removed or if the
> commend should be updated?
New description:
I found the following comment in django\core\mail\__init__.py
# Imported for backwards compatibility and for the sake
# of a cleaner namespace. These symbols used to be in
# django/core/mail.py before the introduction of email
# backends and the subsequent reorganization (See #10355)
#10355 relates to Django 1. As it's out of support, it maybe doesn't make
sense to keep the backwards compatibility. Would it make sense to have a
look at that file and check what of the code can be removed or if the
comment should be updated?
--
Comment:
The imports and comment look fine to me.
--
Ticket URL: <https://code.djangoproject.com/ticket/35372#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018eddab4f61-420b6374-44f0-4aa7-921b-47b18fe8e1ce-000000%40eu-central-1.amazonses.com.
