#35354: Simplify ASGIRequest path handling.
-------------------------------------+-------------------------------------
Reporter: Carlton Gibson | Owner: Carlton
Type: | Gibson
Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: 5.0
Severity: Normal | Resolution:
Keywords: asgi | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Carlton Gibson:
Old description:
> Following the ASGI HTTP Connection Scope docs[0], the provided `path` is
> already the correct value that Django requires.
>
> In combination with `root_path`, from which `script_name` is derived, the
> `path_info` variable can is set.
> It's then redundant to re-calculate `path` from `script_name` and
> `path_info`.
>
> See also, a clarifying discussion on the ASGIref repo[1].
>
> [0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-
> connection-scope
> [1]: https://github.com/django/asgiref/issues/424
New description:
Following the ASGI HTTP Connection Scope docs[0], the provided `path` is
already the correct value that Django requires.
In combination with `root_path`, from which `script_name` is derived, the
`path_info` variable is set.
It's then redundant to re-calculate `path` from `script_name` and
`path_info`.
See also, a clarifying discussion on the ASGIref repo[1].
[0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-
scope
[1]: https://github.com/django/asgiref/issues/424
--
--
Ticket URL: <https://code.djangoproject.com/ticket/35354#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018ead6a2032-3fff5387-c674-44a5-86da-8550418296c4-000000%40eu-central-1.amazonses.com.
