#35285: Optimize ForeignObject._check_unique_target
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Adam Johnson):
Yes, we have lots of test coverage for this check. The tests added in
80dac8c33e7f6f22577e4346f44e4c5ee89b648c are still there and there are
more in `tests/invalid_models_tests/test_relative_fields.py` like
`test_foreign_object_to_partially_unique_field` and
`test_foreign_object_to_unique_field_with_meta_constraint`.
Commenting/replacing any of the old three clauses to create
`unique_foreign_fields` causes a test failure or a check failure for test
models, preventing the tests from running. Similarly with the optimized
version.
--
Ticket URL: <https://code.djangoproject.com/ticket/35285#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018e24ae5dcb-8cf54f18-7af5-47c4-8eff-fa7317ca4a0a-000000%40eu-central-1.amazonses.com.
