#35237: Improve
------------------------------------------------+--------------------------
Reporter: Adam Johnson | Owner: nobody
Type: Cleanup/optimization | Status: assigned
Component: Core (System checks) | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+--------------------------
In `ModelAdminChecks`, the `_check_action_permission_methods` and
`_check_actions_uniqueness` both fetch the actions. By combining them,
this duplicate work can be eliminated.
Additionally, the lower method `ModelAdmin._get_action_description()` is
wasteful as it computes a default name even when one is defined. This can
be deferred and cached.
In a project I’ve profiled, these changes take the admin action checks
from 0.86ms (2.1%) to 0.36ms (0.9%).
--
Ticket URL: <https://code.djangoproject.com/ticket/35237>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018dc398e210-b013c2fb-39bb-4efc-b803-4200ec867992-000000%40eu-central-1.amazonses.com.
