#34849: Appending django.contrib.postgres to the INSTALLED_APPS via
@modify_settings crashes.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
> Shouldn't Jenkins have picked this up earlier, ...
No, it shouldn't. First of all we run the entire test suite not random
subsets of test classes. Secondly, this is quite tricky and you have to
debug how types are registered for `django.contrib.postgresql` and how
`@modify_settings` works:
- types are registered when connection is created by `connection_created`
handler, so it's not when app is initialized, so far so good,
- when `@modify_settings` manipulates `INSTALLED_APPS` then we undo
effects of `PostgresConfig.ready()`,
- `@modify_settings` calls `PostgresConfig.ready()` again, tries to
registered handlers for existing connections and hits the database to
select OIDs.
--
Ticket URL: <https://code.djangoproject.com/ticket/34849#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018aaf33725d-d8040a75-655e-4123-8660-23f24bbbc82e-000000%40eu-central-1.amazonses.com.
