#34768: Calling `colorama.init()` on module load can have unwanted side effects
-------------------------------------+-------------------------------------
Reporter: Charlie DeTar | Owner: Sulabh
Type: | Katila
Cleanup/optimization | Status: closed
Component: Core (Management | Version: 4.2
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:9 Tim Graham]:
> The build for django-snowflake runs on GitHub actions with ubuntu-
latest. It seems that colorama 0.4.4 is preinstalled and thus after this
change the build fails with `module 'colorama' has no attribute
'just_fix_windows_console'`. I think this situation should be handled
gracefully so that third-party package developers aren't required to
upgrade colorama as a part of their builds.
Agreed, check out [https://github.com/django/django/pull/17218 PR].
--
Ticket URL: <https://code.djangoproject.com/ticket/34768#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018a51cb716d-43034bf2-bd06-440f-9968-7d299cf06160-000000%40eu-central-1.amazonses.com.
