#34542: Required fields allowed to be blank are not accepted non-interactively
using createsuperuser
-------------------------------------+-------------------------------------
     Reporter:  Lantizia             |                    Owner:  Anvansh
                                     |  Singh
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.auth         |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:  auth                 |             Triage Stage:  Accepted
  createsuperuser superuser email    |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce):

 Replying to [comment:23 Mateusz Więckowski]:
 >
 > At the moment I am confident that my current solution works, but before
 doing the PR I have just one question - should I write tests as well? In
 the ticket details, it says 'Needs tests: no', but in the guide about
 creating a PR, it's mentioned that tests are always needed, except for
 documentation changes.

 Yes you should write tests. The 'Needs tests' area of the ticket is marked
 as 'Yes' when there was a patch that got reviewed and it was missing
 tests, then this is part of the feedback as to why the patch has not been
 accepted. 👍

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34542#comment:24>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701899406b25b-c7228501-3979-4494-95df-cf58a1332389-000000%40eu-central-1.amazonses.com.

Reply via email to