#34616: Incorrect code example in 5.0 release notes
-----------------------------------------+------------------------
               Reporter:  David Smith    |          Owner:  nobody
                   Type:  Uncategorized  |         Status:  new
              Component:  Uncategorized  |        Version:  4.2
               Severity:  Normal         |       Keywords:
           Triage Stage:  Unreviewed     |      Has patch:  0
    Needs documentation:  0              |    Needs tests:  0
Patch needs improvement:  0              |  Easy pickings:  0
                  UI/UX:  0              |
-----------------------------------------+------------------------
 The 5.0 release notes have a code example of a form and its fields being
 written in Django Template Language.

 However the example shows `field.label` being used. This would give the
 field's label this world be "name", in the line linked below.

 Instead I believe this example should use `field.label_tag` which would
 give ` <label ...>name:</label>`. This is closer to what the template is
 actually doing.

 https://github.com/django/django/blob/main/docs/releases/5.0.txt#L62

 
https://github.com/django/django/blob/main/django/forms/templates/django/forms/field.html#L5

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34616>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070188756d1f23-86b0d3f5-e136-4541-9567-a98b59f7d7a3-000000%40eu-central-1.amazonses.com.

Reply via email to