#34455: i18n_patterns() not respecting prefix_default_language=False
-------------------------------------+-------------------------------------
Reporter: Oussama Jarrousse | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: | Version: 4.2
Internationalization |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
internationalization, i18n, |
prefix_default_language |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mohit Singh Sinsniwal):
Replying to [comment:17 Sarah Boyce]:
> Hi Mohit 👋 sorry I started to have a look and should have said so on
the ticket
>
> You can see here where I think the issue could be solved (doesn't mean
it's where it should be https://github.com/django/django/pull/16735).
> I think it's something around the whole `en-us` falling back to `en` and
then that is different to the setting value for `LANGUAGE_CODE` 🤔
>
> In general how I would approach a ticket is to write a regression test
first and then see if you can get that passing without breaking things in
other places
Hi Sarah,
Thank you for solving the issue.
No problem, I understand that it would have taken me a lot of time to
solve as this was my first ticket on djangoproject. Thank you for your
guidance. I will try to write tests first in the future. Also, thank you
to Mariusz for being patient with me and bearing with my absurd mistakes.
--
Ticket URL: <https://code.djangoproject.com/ticket/34455#comment:20>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070187582072a3-6d2dc1d7-95f6-4f7a-9f9e-dfd2c19f8d77-000000%40eu-central-1.amazonses.com.
