#34457: makemigrations --check no longer prints the changes
-----------------------------------------+------------------------
               Reporter:  David Sanders  |          Owner:  nobody
                   Type:  Uncategorized  |         Status:  new
              Component:  Migrations     |        Version:  4.2
               Severity:  Normal         |       Keywords:
           Triage Stage:  Unreviewed     |      Has patch:  1
    Needs documentation:  0              |    Needs tests:  0
Patch needs improvement:  0              |  Easy pickings:  0
                  UI/UX:  0              |
-----------------------------------------+------------------------
 As a result of #34051 the `--check` flag on makemigrations simply exits 1
 without writing any changes.

 This makes sense as it's consistent with other uses of `--check`.

 However one consequence of this change is that my CI server no longer
 prints the changes it thinks I need to make – and this makes the
 situations where the local dev & CI are different, harder to debug.

 I'd like to propose reverting this change and instead forcing `--dry-run`
 to be set if `--check` is supplied. This way makemigrations goes through
 the motions of what it needs to write, outputting those changes to the log
 but the dry flag prevents any migrations from being written.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34457>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701874c557872-9c2a8f48-3008-4fb3-b83f-1d187b28bb4a-000000%40eu-central-1.amazonses.com.

Reply via email to