#34431: DateTimeField.input_formats change from Django 3.1 is documented
improperly
-------------------------------------+-------------------------------------
Reporter: stefan6419846 | Owner: Edison
Type: | Wang
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 3.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
Comment:
> I believe that the changes made to
{{{django.forms.fields.DateTimeField.input_formats}}} from
[https://github.com/django/django/commit/188b003014dc727ca22f7fafb21cf2fa0b3472d2]
are redundant. The previous initialization is already lazily evaluated, so
there is no need to include the class {{{DateTimeFormatsIterator}}} to
define the generator. Should this part be reverted?
`get_format_lazy()` doesn't support multiple settings so
`DateTimeFormatsIterator` is necessary.
--
Ticket URL: <https://code.djangoproject.com/ticket/34431#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701872c21d87a-aaa1e6b8-885d-4671-8f0a-39bd2719af79-000000%40eu-central-1.amazonses.com.
