#34436: `makemigrations --check` fails with error code 1 if system checks
identify
warnings
-------------------------------+--------------------------------------
Reporter: James Addison | Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 4.2
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Comment (by James Addison):
To close this off - while I don't think we were talking the same language
in the conversation back and forth here, this was very much a red
herring/rabbit hole. For the benefit of others who might encounter this
behaviour, it's worthwhile adding the following.
`manage.py makemigrations --check` was ''correctly'' returning an exit
code of `1` because of the
[https://docs.djangoproject.com/en/4.1/releases/4.0/#migrations-
autodetector-changes migration autodetector changes in Django 4.0].
This manifested somewhat indirectly in a [https://github.com/python-
social-auth/social-app-django/issues/429#issuecomment-1485542714 3rd party
app], which is where the missing migration (although a no-op migration!)
needs to be added. Until that is done in 3rd party apps, continuous
integration relying on `makemigrations --check` will continue to fail.
--
Ticket URL: <https://code.djangoproject.com/ticket/34436#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070187242dd6e5-ec75b448-c828-48ab-9008-acbc5dbc080d-000000%40eu-central-1.amazonses.com.
