#34301: "show_save_as_new" in admin can add without this permission
-------------------------------------+-------------------------------------
Reporter: Equipe de TI da | Owner: Frédéric
Zara Falcão | Mheir
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: save_as | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Frédéric Mheir):
* needs_tests: 1 => 0
Comment:
Replying to [comment:12 Mariusz Felisiak]:
> Replying to [comment:11 Frédéric Mheir]:
> > Replying to [comment:10 Mariusz Felisiak]:
> > Hi Mariusz! Thanks a lot for your feedback. By making making a test
that ensures "show_save_as_new" tag is False when "has_add_permission" is
False (and other conditions True), would that be considered proper
regression test? The logic is that only it would pass only with the patch.
>
> Yes, exactly.
Thanks! Just pushed the changes to the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/34301#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070186286d5946-e1bb83e8-3b65-4b61-9f15-61a7f6067a44-000000%40eu-central-1.amazonses.com.
