#33955: AttributeError in admindocs ViewDetailView
-----------------------------------+--------------------------------------
Reporter: Greg Kaleka | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Description changed by Greg Kaleka:
Old description:
> In Django 4.1, the admindocs `ViewDetailView` raises an `AttributeError`.
> I'm not clear on why `_active` is missing the `local_value` attribute
> when `_is_callback` is called.
>
> Reproduction steps:
>
> 1. Create a new project with Django 4.1
> 2. Include `django.contrib.admindocs` in your installed apps
> 3. Add the urls to your urlconf: `path("admindocs/",
> include("django.contrib.admindocs.urls"))`
> 4. Go to `localhost:8000/admindocs/views/` and click on any view to go to
> the `ViewDetailView`
>
> Quick and dirty fix in `django/contrib/admindocs/utils.py`:
>
> {{{
> #!div style="font-size: 80%"
> Code highlighting:
> {{{#!python
> def _is_callback(name, urlresolver=None):
> if not hasattr(_active, "local_value"):
> _active.local_value = _callback_strs
> if urlresolver and not urlresolver._populated:
> register_callback(urlresolver, _active.local_value)
> return name in _active.local_value
> }}}
> }}}
>
> and here's the full traceback before the fix:
>
> {{{
> Internal Server Error:
> /admindocs/views/django.contrib.admindocs.views.BaseAdminDocsView/
> Traceback (most recent call last):
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/core/handlers/exception.py", line 55, in inner
> response = get_response(request)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/core/handlers/base.py", line 197, in _get_response
> response = wrapped_callback(request, *callback_args,
> **callback_kwargs)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/views/generic/base.py", line 103, in view
> return self.dispatch(request, *args, **kwargs)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/utils/decorators.py", line 46, in _wrapper
> return bound_method(*args, **kwargs)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/contrib/auth/decorators.py", line 23, in
> _wrapped_view
> return view_func(request, *args, **kwargs)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/contrib/admindocs/views.py", line 50, in dispatch
> return super().dispatch(request, *args, **kwargs)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/views/generic/base.py", line 142, in dispatch
> return handler(request, *args, **kwargs)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/views/generic/base.py", line 216, in get
> context = self.get_context_data(**kwargs)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/contrib/admindocs/views.py", line 185, in
> get_context_data
> view_func = self._get_view_func(view)
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/contrib/admindocs/views.py", line 169, in
> _get_view_func
> if _is_callback(view):
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/django/contrib/admindocs/utils.py", line 258, in
> _is_callback
> return name in _active.local_value
> File "/Users/gkaleka/dev/testing/django_41_testfix/.venv/lib/python3.9
> /site-packages/asgiref/local.py", line 105, in __getattr__
> raise AttributeError(f"{self!r} object has no attribute {key!r}")
> AttributeError: <asgiref.local.Local object at 0x10a4f7670> object has no
> attribute 'local_value'
> }}}
New description:
In Django 4.1, the admindocs `ViewDetailView` raises an `AttributeError`.
I'm not clear on why `_active` is missing the `local_value` attribute when
`_is_callback` is called.
Reproduction steps:
1. Create a new project with Django 4.1
2. Run `manage.py migrate` and `manage.py createsuperuser`
3. Include `django.contrib.admindocs` in your installed apps
4. Add the urls to your urlconf: `path("admindocs/",
include("django.contrib.admindocs.urls"))`
5. Go to `localhost:8000/admindocs/views/` and click on any view to go to
the `ViewDetailView`
Quick and dirty fix in `django/contrib/admindocs/utils.py`:
{{{
#!div style="font-size: 80%"
Code highlighting:
{{{#!python
def _is_callback(name, urlresolver=None):
if not hasattr(_active, "local_value"):
_active.local_value = _callback_strs
if urlresolver and not urlresolver._populated:
register_callback(urlresolver, _active.local_value)
return name in _active.local_value
}}}
}}}
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33955#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070182d14fc430-f13fd754-6f97-4c06-8811-b34994d4c222-000000%40eu-central-1.amazonses.com.
