#33750: Use <div> for timezone warning in admin
-------------------------------------+-------------------------------------
Reporter: Florian Demmer | Owner: nobody
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Description changed by Florian Demmer:
Old description:
> Previously help_text was inserted as <p> in admin. This was changed in
> #27207 to use a <div>.
>
> The
> [https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js#L61
> addTimezoneWarning()] function has "always" added the warning by
> inserting a <br> and <span>.
>
> Also using a <div> with the help class here avoids problems with left-
> alignment of the inserted text and removes the need for the <br>.
New description:
Previously help_text was inserted as <p> in admin. This was changed in
#27207 to use a <div>.
The
[https://github.com/django/django/blob/0dd29209091280ccf34e07c9468746c396b7778e/django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js#L61
addTimezoneWarning()] function has "always" added the warning by inserting
a <br> and <span>.
Also using a <div> with the help class here avoids problems with left-
alignment of the inserted text (see attachment) and removes the need for
the <br>.
PR: https://github.com/django/django/pull/15743
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33750#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070181102bd708-facf9d30-d8aa-4772-b21f-e551885828f0-000000%40eu-central-1.amazonses.com.
