#33724: Changing from list to set in `exclude` raises errors, and is not
documented.
-------------------------------------+-------------------------------------
     Reporter:  אורי                 |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  4.1
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by אורי):

 Replying to [comment:3 Mariusz Felisiak]:
 > `exclude` can be a list or set, it depends from where `clean_fields()`
 is called, so it's safer to handle both types, e.g.
 > {{{#!python
 > def clean_fields(self, exclude=None):
 >     if exclude is None:
 >         exclude = set()
 >     else:
 >         exclude = set(exclude)
 >     ...
 > }}}

 Thank you.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33724#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180dbdb1d89-45964f50-a1cf-4ae9-94b3-575ebc1051e4-000000%40eu-central-1.amazonses.com.

Reply via email to