#33569: Add support for multiple values for the x-forwarded-proto header
-------------------------------------+-------------------------------------
     Reporter:  Thomas Schmidt       |                    Owner:  Thomas
         Type:                       |  Schmidt
  Cleanup/optimization               |                   Status:  new
    Component:  HTTP handling        |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Thomas Schmidt):

 I can re-open the closed PR and update it to take the comments made here
 into account, so we can discuss it.

 Summary:
 * leftmost value determine the protocol if multiple, comma-separated
 values are present
 * https://docs.djangoproject.com/en/4.0/ref/settings/#std:setting-
 SECURE_PROXY_SSL_HEADER needs to be updated to document the change
 * https://docs.djangoproject.com/en/4.0/ref/request-
 response/#django.http.HttpRequest.is_secure may also need to be updated,
 although I'm not certain it is necessary?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33569#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107017f74c9e9fd-d9ded54d-0eb3-482e-9cf4-67583dee0d66-000000%40eu-central-1.amazonses.com.

Reply via email to