#33436: Test that is not correct (?)
-------------------------------------+-------------------------------------
Reporter: raydeal | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database | Version: 4.0
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
I am in doubt what this test exactly test:
tests/foreign_object/test_empty_join.py
{{{
tests/foreign_object/test_empty_join.RestrictedConditionsTests.test_restrictions_with_no_joining_columns
}}}
The test was introduced in [https://code.djangoproject.com/ticket/25064
#25064], [https://code.djangoproject.com/ticket/27392 #27392] tickets and
two more small changes in test code.
In my opinion the test doesn't test django functionality important from
end user point of view or even development. It probably only test the idea
of the author. Tested model, its relational fields, are fully customised
not using public ORM API, just overwrite class methods.
I would suggest to delete the test because it doesn't bring an important
value to django code quality.
--
Ticket URL: <https://code.djangoproject.com/ticket/33436>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/050.7c9ce74149fff8b59ac34202f2fe2a11%40djangoproject.com.
