#19580: Unify reverse foreign key and m2m unsaved model querying
-------------------------------------+-------------------------------------
Reporter: Anssi Kääriäinen | Owner: raydeal
Type: | Status: assigned
Cleanup/optimization |
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by raydeal):
Replying to [comment:38 Pavel Druzhinin]:
> Replying to [comment:37 Mariusz Felisiak]:
> > Thanks for this patch, however it's not ready for review. Please fix
tests and `isort`.
>
> Hello, it seems I need help to fix this error. I'm not sure code from
previous contributor is correct and I don't fully understand the subject
of this bug (m2m relations).
> What is better to do: remove label `easy pickings` and try another bug
or someone could help me with fixing this bug?
>
> P.S. Please, don't think for nagging. I really don't want to drop the
ticket silently and want to continue to contribute at the same time.
Thanks in advance with your advice how best to proceed.
Would you like to carry on with the ticket? After reading comments and
code my understanding is to make FK reverse working the same way as m2m
when id=None, what is done in code, but message is a bit different, it
would be good to have similar message in both cases. It will require amend
m2m tests as well after update with current django version.
--
Ticket URL: <https://code.djangoproject.com/ticket/19580#comment:40>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.15198a282c9147004bd23efc674b329c%40djangoproject.com.
