#33372: GISModelAdmin.gis_widget_kwargs cannot be used due to signature
mismatch.
-------------------------------------+-------------------------------------
Reporter: Nick Pope | Owner: Alexander
| Filimonov
Type: Bug | Status: closed
Component: GIS | Version: 4.0
Severity: Normal | Resolution: invalid
Keywords: gismodeladmin, | Triage Stage:
gis_widget_kwargs | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: assigned => closed
* severity: Release blocker => Normal
* cc: Claude Paroz (added)
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* has_patch: 1 => 0
* resolution: => invalid
Comment:
Replying to [ticket:33372 Nick Pope]:
> `OSMWidget` and `BaseGeometryWidget` have `.__init__(self, attrs=None)`,
not `.__init__(self, **kwargs)`, so this is broken.
>
> Marking as a release blocker as this is a bug in a new feature
introduced in 4.0.
I wouldn't say it's broken, you can set `gis_widget_kwargs = {'attrs':
{...}}`. Defining widgets with more than `attrs` or a different signature
is reasonable (e.g. `SplitDateTimeWidget` or `ChoiceWidget`). IMO we
should leave wide support for all options.
--
Ticket URL: <https://code.djangoproject.com/ticket/33372#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.cf67fae65e1aee89a706bf77ebe13ad9%40djangoproject.com.
